Fix another coverity-spotted memleak

diff --git a/ChangeLog b/ChangeLog
index dc4cfe86c649b0a954590aa1d5c43166481516ca..ef866292f95eaa6068170ca0e294ef54ba8c89d7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Changes in version 0.2.2.10-alpha - 2010-??-??
+  o Minor bugfixes:
+    - Fix a memleak in the EXTENDCIRCUIT logic. Spotted by coverity.
+      Bugfix on 0.2.2.9-alpha.
+
 Changes in version 0.2.2.9-alpha - 2010-02-22
   o Directory authority changes:
     - Change IP address for dannenberg (v3 directory authority), and

diff --git a/src/or/control.c b/src/or/control.c
index 0f71855286aafaf05a7a9b97433b68a28bbc72c6..5101fdef42a381f1f602cafcc74c8518a68c0617 100644 (file)
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -2121,6 +2121,8 @@ handle_control_extendcircuit(control_connection_t *conn, uint32_t len,
   if (!zero_circ && !(circ = get_circ(smartlist_get(args,0)))) {
     connection_printf_to_buf(conn, "552 Unknown circuit \"%s\"\r\n",
                              (char*)smartlist_get(args, 0));
+    SMARTLIST_FOREACH(args, char *, cp, tor_free(cp));
+    smartlist_free(args);
     goto done;
   }