]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.11] Fix test_importlib.test_side_effect_import() (GH-104840) (#104843)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 25 May 2023 00:35:34 +0000 (17:35 -0700)
committerGitHub <noreply@github.com>
Thu, 25 May 2023 00:35:34 +0000 (02:35 +0200)
Fix test_importlib.test_side_effect_import() (GH-104840)

Wait until the thread spawn by the import completes to avoid dangling
threads. With this fix, the following command no longer fails:

./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20
(cherry picked from commit 426950993f6a39cdf3f6a3333ac8b518833c7e61)

Co-authored-by: Victor Stinner <vstinner@python.org>
Lib/test/test_importlib/test_threaded_import.py

index 9aeeb5e686e93687b7f4484646c9c81625ff92b7..16c0513b585a8664bb3c9841d18a78f26f0f8981 100644 (file)
@@ -244,7 +244,8 @@ class ThreadedImportTests(unittest.TestCase):
         self.addCleanup(forget, TESTFN)
         self.addCleanup(rmtree, '__pycache__')
         importlib.invalidate_caches()
-        __import__(TESTFN)
+        with threading_helper.wait_threads_exit():
+            __import__(TESTFN)
         del sys.modules[TESTFN]
 
     def test_concurrent_futures_circular_import(self):