]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.6] bpo-31448, test_poplib: Fix ResourceWarning (GH-3542) (#3543)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 13 Sep 2017 13:09:44 +0000 (06:09 -0700)
committerVictor Stinner <victor.stinner@gmail.com>
Wed, 13 Sep 2017 13:09:44 +0000 (06:09 -0700)
Call POP3.close(), don't close close directly the sock attribute.
(cherry picked from commit d165e14e29b45a22450263722f5c2c386c3a748a)

Lib/test/test_poplib.py

index e5b16dc98a41113d47e81c7ede3797cea5eb1f19..6bc9739780855cf2c5e7564530a66ab68cec9139 100644 (file)
@@ -483,7 +483,7 @@ class TestTimeouts(TestCase):
         finally:
             socket.setdefaulttimeout(None)
         self.assertEqual(pop.sock.gettimeout(), 30)
-        pop.sock.close()
+        pop.close()
 
     def testTimeoutNone(self):
         self.assertIsNone(socket.getdefaulttimeout())
@@ -493,12 +493,12 @@ class TestTimeouts(TestCase):
         finally:
             socket.setdefaulttimeout(None)
         self.assertIsNone(pop.sock.gettimeout())
-        pop.sock.close()
+        pop.close()
 
     def testTimeoutValue(self):
         pop = poplib.POP3(HOST, self.port, timeout=30)
         self.assertEqual(pop.sock.gettimeout(), 30)
-        pop.sock.close()
+        pop.close()
 
 
 def test_main():