]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
generic: phy: adm6996: fix build on 6.18 kernel 22917/head
authorShiji Yang <yangshiji66@outlook.com>
Sat, 11 Apr 2026 00:34:00 +0000 (08:34 +0800)
committerRobert Marko <robimarko@gmail.com>
Tue, 14 Apr 2026 09:52:35 +0000 (11:52 +0200)
devm_gpio_request() was removed since kernel 6.17. Convert it to
devm_gpio_request_one() to fix:

target/linux/generic/files/drivers/net/phy/adm6996.c: In function 'adm6996_gpio_probe':
target/linux/generic/files/drivers/net/phy/adm6996.c:1183:15: error: implicit declaration of function 'devm_gpio_request'; did you mean 'devm_gpio_request_one'? [-Wimplicit-function-declaration]
 1183 |         ret = devm_gpio_request(&pdev->dev, priv->eecs, "adm_eecs");
      |               ^~~~~~~~~~~~~~~~~
      |               devm_gpio_request_one

Link: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.18.y&id=a5589313383074c48a1b3751d592a6e084ae0573
Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
Link: https://github.com/openwrt/openwrt/pull/22917
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/generic/files/drivers/net/phy/adm6996.c

index 7394cb6e0c804866aa3c094a2ffa5c2172761eba..063e53c41a7e926e6027abf7c692e7e672c4053e 100644 (file)
@@ -1180,13 +1180,16 @@ static int adm6996_gpio_probe(struct platform_device *pdev)
        priv->read = adm6996_read_gpio_reg;
        priv->write = adm6996_write_gpio_reg;
 
-       ret = devm_gpio_request(&pdev->dev, priv->eecs, "adm_eecs");
+       ret = devm_gpio_request_one(&pdev->dev, priv->eecs,
+                                   GPIOF_IN, "adm_eecs");
        if (ret)
                return ret;
-       ret = devm_gpio_request(&pdev->dev, priv->eedi, "adm_eedi");
+       ret = devm_gpio_request_one(&pdev->dev, priv->eedi,
+                                   GPIOF_IN, "adm_eedi");
        if (ret)
                return ret;
-       ret = devm_gpio_request(&pdev->dev, priv->eesk, "adm_eesk");
+       ret = devm_gpio_request_one(&pdev->dev, priv->eesk,
+                                   GPIOF_IN, "adm_eesk");
        if (ret)
                return ret;