]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
testsuite: add FIXME note about libkmod-internal.h include
authorEmil Velikov <emil.l.velikov@gmail.com>
Sat, 18 Jul 2026 15:23:18 +0000 (16:23 +0100)
committerLucas De Marchi <ldemarchi@kernel.org>
Tue, 28 Jul 2026 14:11:03 +0000 (09:11 -0500)
We really do not want to have dependency on an internal header(s), since
it opens the possibility of leaking implementation details into what
should be API level tests.

Although, it could be that we should remove kmod_list from the public
API all together... Something for another day either way.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/450
Signed-off-by: Lucas De Marchi <ldemarchi@kernel.org>
testsuite/test-blacklist.c

index b7f3967e9db1e455373ddc0ff05e5c01935cbde8..a9e0a92893201c5ce7c6c09899d51effb16b9a61 100644 (file)
@@ -16,6 +16,7 @@
 
 /* good luck building a kmod_list outside of the library... makes this blacklist
  * function rather pointless */
+/* FIXME: convert the test so we don't need the internal header */
 #include <libkmod/libkmod-internal.h>
 
 #include "testsuite.h"