]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amd/display: should support dmub hw lock on Replay
authorMartin Tsai <martin.tsai@amd.com>
Fri, 2 Feb 2024 06:39:29 +0000 (14:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Mar 2025 20:59:55 +0000 (21:59 +0100)
commit bfeefe6ea5f18cabb8fda55364079573804623f9 upstream.

[Why]
Without acquiring DMCUB hw lock, a race condition is caused with
Panel Replay feature, which will trigger a hang. Indicate that a
lock is necessary to prevent this when replay feature is enabled.

[How]
To allow dmub hw lock on Replay.

Reviewed-by: Robin Chen <robin.chen@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Martin Tsai <martin.tsai@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/amd/display/dc/dce/dmub_hw_lock_mgr.c

index 2aa0e01a6891b07e00143d7e803774a822616abf..d0997126a00f136cb08169614c246874a7ddf4f5 100644 (file)
@@ -65,5 +65,9 @@ bool should_use_dmub_lock(struct dc_link *link)
 {
        if (link->psr_settings.psr_version == DC_PSR_VERSION_SU_1)
                return true;
+
+       if (link->replay_settings.replay_feature_enabled)
+               return true;
+
        return false;
 }