]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 31 May 2022 12:10:05 +0000 (15:10 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:44:59 +0000 (18:44 +0200)
[ Upstream commit 86360030cc5117596626bef1d937277cd2bebe05 ]

The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return
false on failure.  It should not return negatives because that means
succes/true.

Fixes: fcb6aa86532c ("act_ct: Support GRE offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Toshiaki Makita <toshiaki.makita1@gmail.com>
Link: https://lore.kernel.org/r/YpYFnbDxFl6tQ3Bn@kili
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/act_ct.c

index b1f502fce595667ab66eab85bc66bf88eba3bc5e..b3ca837fd4e82a37ef08ef6b833255707ed29cd8 100644 (file)
@@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb,
                break;
 #endif
        default:
-               return -1;
+               return false;
        }
 
        if (ip6h->hop_limit <= 1)