]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Document that we are unlikely to underflow session group IDs.
authorNick Mathewson <nickm@torproject.org>
Fri, 15 Jun 2012 14:05:21 +0000 (10:05 -0400)
committerNick Mathewson <nickm@torproject.org>
Fri, 15 Jun 2012 19:07:53 +0000 (15:07 -0400)
src/or/connection.c

index 9bbab192012a8d96fcb64f2ce9768c763390e753..c22068b823d5afe2ae444d79faca0a1f2285b335 100644 (file)
@@ -1048,7 +1048,12 @@ connection_listener_new(const struct sockaddr *listensockaddr,
     if (port_cfg->session_group >= 0) {
       lis_conn->session_group = port_cfg->session_group;
     } else {
-      /* XXXX023 This can wrap after ~INT_MAX ports are opened. */
+      /* This can wrap afuter ~INT_MAX listeners are opened.  But I don't
+       * believe that matters, since you would need to open a ridiculous
+       * number of listeners while keeping the early ones open before you ever
+       * hit this.  An OR with a dozen ports open, for example, would have to
+       * close and re-open its listers every second for 4 years nonstop.
+       */
       lis_conn->session_group = global_next_session_group--;
     }
   }