]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/ingenic: ipu: Switch to drm_atomic_get_new_crtc_state()
authorMaxime Ripard <mripard@kernel.org>
Tue, 30 Sep 2025 10:59:26 +0000 (12:59 +0200)
committerMaxime Ripard <mripard@kernel.org>
Mon, 6 Oct 2025 11:59:09 +0000 (13:59 +0200)
The ingenic IPU atomic_set_property implementation uses the deprecated
drm_atomic_get_existing_crtc_state() helper.

This hook is called during the state building process, before
atomic_check, and thus before the states are swapped. The existing state
thus points to the new state, and we can use
drm_atomic_get_new_crtc_state() instead.

Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/20250930-drm-no-more-existing-state-v5-11-eeb9e1287907@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/ingenic/ingenic-ipu.c

index 26ebf424d63ec21ccee80221745c3e8bcc6b3d7f..2574a4b4d40a2c27cb212114117829d9f6ab3ddb 100644 (file)
@@ -705,7 +705,7 @@ ingenic_ipu_plane_atomic_set_property(struct drm_plane *plane,
        ipu->sharpness = val;
 
        if (state->crtc) {
-               crtc_state = drm_atomic_get_existing_crtc_state(state->state, state->crtc);
+               crtc_state = drm_atomic_get_new_crtc_state(state->state, state->crtc);
                if (WARN_ON(!crtc_state))
                        return -EINVAL;