s4/policy/gp_filesys: avoid SIZE_MAX smbcli write (CID 1034779)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/lib/policy/gp_filesys.c b/source4/lib/policy/gp_filesys.c
index 267762dd27dbe99bec0de187161711376346a921..69fb143c68703d2774d2d605978734974b641f55 100644 (file)
--- a/source4/lib/policy/gp_filesys.c
+++ b/source4/lib/policy/gp_filesys.c
@@ -482,6 +482,12 @@ static NTSTATUS push_recursive (struct gp_context *gp_ctx, const char *local_pat
                        }
                        total_read = 0;
                        while ((nread = read(local_fd, &buf, sizeof(buf)))) {
+                               if (nread == -1) {
+                                       DBG_ERR("read failed with errno %s\n",
+                                               strerror(errno));
+                                       status = NT_STATUS_UNSUCCESSFUL;
+                                       goto done;
+                               }
                                smbcli_write(gp_ctx->cli->tree, remote_fd, 0,
                                                &buf, total_read, nread);
                                total_read += nread;