]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Confim we want certificates from fallbacks
authorteor (Tim Wilson-Brown) <teor2345@gmail.com>
Wed, 11 May 2016 17:08:45 +0000 (13:08 -0400)
committerteor (Tim Wilson-Brown) <teor2345@gmail.com>
Wed, 11 May 2016 17:08:45 +0000 (13:08 -0400)
Comment-only change

src/or/routerlist.c

index 85e9e7d83470e78a1186bd3e443bacce582a9a0f..d40d704a1d03b0396629bc5eab33fe7b5d8c27b2 100644 (file)
@@ -913,7 +913,8 @@ authority_certs_fetch_missing(networkstatus_t *status, time_t now)
 
     if (smartlist_len(fps) > 1) {
       resource = smartlist_join_strings(fps, "", 0, NULL);
-      /* XXX - do we want certs from authorities or mirrors? - teor */
+      /* We want certs from mirrors, because they will almost always succeed.
+       */
       directory_get_from_dirserver(DIR_PURPOSE_FETCH_CERTIFICATE, 0,
                                    resource, PDS_RETRY_IF_NO_SERVERS,
                                    DL_WANT_ANY_DIRSERVER);
@@ -959,7 +960,8 @@ authority_certs_fetch_missing(networkstatus_t *status, time_t now)
 
     if (smartlist_len(fp_pairs) > 1) {
       resource = smartlist_join_strings(fp_pairs, "", 0, NULL);
-      /* XXX - do we want certs from authorities or mirrors? - teor */
+      /* We want certs from mirrors, because they will almost always succeed.
+       */
       directory_get_from_dirserver(DIR_PURPOSE_FETCH_CERTIFICATE, 0,
                                    resource, PDS_RETRY_IF_NO_SERVERS,
                                    DL_WANT_ANY_DIRSERVER);