]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: qla2xxx: Fix optrom version displayed in FDMI
authorShreyas Deodhar <sdeodhar@marvell.com>
Wed, 10 Jul 2024 17:10:54 +0000 (22:40 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Aug 2024 07:00:35 +0000 (09:00 +0200)
commit 348744f27a35e087acc9378bf53537fbfb072775 upstream.

Bios version was popluated for FDMI response. Systems with EFI would show
optrom version as 0.  EFI version is populated here and BIOS version is
already displayed under FDMI_HBA_BOOT_BIOS_NAME.

Cc: stable@vger.kernel.org
Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-9-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/qla2xxx/qla_gs.c

index 1cf9d200d563070b53d61df25ae7d5abee50b02a..10192f947658412359a8a926edf09a0f8eeb4919 100644 (file)
@@ -1710,7 +1710,7 @@ qla2x00_hba_attributes(scsi_qla_host_t *vha, void *entries,
        eiter->type = cpu_to_be16(FDMI_HBA_OPTION_ROM_VERSION);
        alen = scnprintf(
                eiter->a.orom_version, sizeof(eiter->a.orom_version),
-               "%d.%02d", ha->bios_revision[1], ha->bios_revision[0]);
+               "%d.%02d", ha->efi_revision[1], ha->efi_revision[0]);
        alen += FDMI_ATTR_ALIGNMENT(alen);
        alen += FDMI_ATTR_TYPELEN(eiter);
        eiter->len = cpu_to_be16(alen);