]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
EDAC/versalnet: Fix off by one in handle_error()
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 27 Sep 2025 12:26:34 +0000 (15:26 +0300)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 13 Oct 2025 15:14:47 +0000 (17:14 +0200)
The priv->mci[] array has NUM_CONTROLLERS so this > comparison needs to be >=
to prevent an out of bounds access.

Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
drivers/edac/versalnet_edac.c

index 7c5db8bf0595b614b6f7b85227fa02198b882790..1ded4c3f02133444931528032000d3583cdc63e3 100644 (file)
@@ -433,7 +433,7 @@ static void handle_error(struct mc_priv  *priv, struct ecc_status *stat,
        phys_addr_t pfn;
        int err;
 
-       if (WARN_ON_ONCE(ctl_num > NUM_CONTROLLERS))
+       if (WARN_ON_ONCE(ctl_num >= NUM_CONTROLLERS))
                return;
 
        mci = priv->mci[ctl_num];