]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libgpo: Initialize struct security_ace array
authorAndreas Schneider <asn@samba.org>
Mon, 8 Jul 2024 09:13:35 +0000 (11:13 +0200)
committerGünther Deschner <gd@samba.org>
Tue, 16 Jul 2024 11:41:33 +0000 (11:41 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/libgpo/gpo_reg.c:708: var_decl: Declaring variable ""ace"" without initializer.
samba-4.20.0rc2/libgpo/gpo_reg.c:755: uninit_use_in_call: Using uninitialized value ""*ace"". Field ""ace->object"" is uninitialized when calling ""make_sec_acl"".
  753|         mask, inherit_flags);
  754|
  755|->  theacl = make_sec_acl(mem_ctx, NT4_ACL_REVISION, 6, ace);
  756|    W_ERROR_HAVE_NO_MEMORY(theacl);
  757|"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
libgpo/gpo_reg.c

index a1a8d7d1a07dc006af7175f9a54e14e6db3d1ebc..9c1e1693b154cb5db4b2e677ee2ff526545534fa 100644 (file)
@@ -705,7 +705,7 @@ static WERROR gp_reg_generate_sd(TALLOC_CTX *mem_ctx,
                                 struct security_descriptor **sd,
                                 size_t *sd_size)
 {
-       struct security_ace ace[6];
+       struct security_ace ace[6] = {};
        uint32_t mask;
 
        struct security_acl *theacl = NULL;