]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
regulator: consumer: Reorder fields in 'struct regulator_bulk_data'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 12 May 2024 11:11:21 +0000 (13:11 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 27 May 2024 00:32:51 +0000 (01:32 +0100)
Based on pahole, 2 holes can be combined in 'struct regulator_bulk_data'.

On x86_64 and allmodconfig, this shrinks the size of the structure from 32
to 24 bytes.

This is usually a win, because this structure is often used for static
global variables.

As an example:
Before:
   text    data     bss     dec     hex filename
   3557     162       0    3719     e87 drivers/gpu/drm/msm/dsi/dsi_cfg.o

After:
   text    data     bss     dec     hex filename
   3477     162       0    3639     e37 drivers/gpu/drm/msm/dsi/dsi_cfg.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://msgid.link/r/35c4edf2dbc6d4f24fb771341ded2989ae32f779.1715512259.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
include/linux/regulator/consumer.h

index 59d0b9a79e6e049c34e22246c3a12471e7b38295..e6f81fc1fb175be21c03a286855c8370380cec97 100644 (file)
@@ -128,11 +128,11 @@ struct regulator;
  *
  * @supply:       The name of the supply.  Initialised by the user before
  *                using the bulk regulator APIs.
+ * @consumer:     The regulator consumer for the supply.  This will be managed
+ *                by the bulk API.
  * @init_load_uA: After getting the regulator, regulator_set_load() will be
  *                called with this load.  Initialised by the user before
  *                using the bulk regulator APIs.
- * @consumer:     The regulator consumer for the supply.  This will be managed
- *                by the bulk API.
  *
  * The regulator APIs provide a series of regulator_bulk_() API calls as
  * a convenience to consumers which require multiple supplies.  This
@@ -140,8 +140,8 @@ struct regulator;
  */
 struct regulator_bulk_data {
        const char *supply;
-       int init_load_uA;
        struct regulator *consumer;
+       int init_load_uA;
 
        /* private: Internal use */
        int ret;