]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Fix another crash bug.
authorMike Perry <mikeperry-git@fscked.org>
Thu, 22 Nov 2012 00:33:16 +0000 (16:33 -0800)
committerMike Perry <mikeperry-git@fscked.org>
Fri, 7 Dec 2012 23:28:38 +0000 (15:28 -0800)
src/or/circuitbuild.c

index aaa195970482af10878553db8a6c2baf9d78f141..8304ad8b89bc888d0c0a9bc90f0e20aa44c1ce4b 100644 (file)
@@ -1501,14 +1501,19 @@ pathbias_get_closed_count(entry_guard_t *guard)
 
   /* Count currently open circuits. Give them the benefit of the doubt */
   for ( ; circ; circ = circ->next) {
+    origin_circuit_t *ocirc = NULL;
     if (!CIRCUIT_IS_ORIGIN(circ) || /* didn't originate here */
-        circ->marked_for_close ||  /* already counted */
-        !circ->cpath || !circ->cpath->extend_info)
+        circ->marked_for_close) /* already counted */
       continue;
 
-    if (TO_ORIGIN_CIRCUIT(circ)->path_state == PATH_STATE_SUCCEEDED &&
+    ocirc = TO_ORIGIN_CIRCUIT(circ);
+
+    if(!ocirc->cpath || !ocirc->cpath->extend_info)
+      continue;
+
+    if (ocirc->path_state == PATH_STATE_SUCCEEDED &&
         (memcmp(guard->identity,
-                TO_ORIGIN_CIRCUIT(circ)->cpath->extend_info->identity_digest,
+                ocirc->cpath->extend_info->identity_digest,
                 DIGEST_LEN)
          == 0)) {
       open_circuits++;