]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
backlight: exit earlier when unknown verb is specified
authorYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 22 Feb 2021 14:00:46 +0000 (23:00 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 22 Feb 2021 14:00:46 +0000 (23:00 +0900)
src/backlight/backlight.c

index f3d53d64625157274340b3fa969a6ecdbd41022f..f9e4f83ab966f0ae2848a278f521a75578967f9d 100644 (file)
@@ -388,6 +388,9 @@ static int run(int argc, char *argv[]) {
         if (argc != 3)
                 return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "This program requires two arguments.");
 
+        if (!STR_IN_SET(argv[1], "load", "save"))
+                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Unknown verb %s.", argv[1]);
+
         umask(0022);
 
         r = mkdir_p("/var/lib/systemd/backlight", 0755);
@@ -503,7 +506,7 @@ static int run(int argc, char *argv[]) {
                         return log_device_error_errno(device, r, "Failed to write %s: %m", saved);
 
         } else
-                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Unknown verb %s.", argv[1]);
+                assert_not_reached("Unknown verb.");
 
         return 0;
 }