ovl: port ovl_setattr() to cred guard

Use the scoped ovl cred guard.

Link: https://patch.msgid.link/20251117-work-ovl-cred-guard-v4-13-b31603935724@kernel.org
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index e11f310ce092adc871506b7632b3b22efaa38873..7b28318b7f31375ccb732e34b9b69d484fa3b2b6 100644 (file)
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -25,7 +25,6 @@ int ovl_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
        struct ovl_fs *ofs = OVL_FS(dentry->d_sb);
        bool full_copy_up = false;
        struct dentry *upperdentry;
-       const struct cred *old_cred;
 
        err = setattr_prepare(&nop_mnt_idmap, dentry, attr);
        if (err)
@@ -78,9 +77,8 @@ int ovl_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
                        goto out_put_write;
 
                inode_lock(upperdentry->d_inode);
-               old_cred = ovl_override_creds(dentry->d_sb);
-               err = ovl_do_notify_change(ofs, upperdentry, attr);
-               ovl_revert_creds(old_cred);
+               with_ovl_creds(dentry->d_sb)
+                       err = ovl_do_notify_change(ofs, upperdentry, attr);
                if (!err)
                        ovl_copyattr(dentry->d_inode);
                inode_unlock(upperdentry->d_inode);