]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.12] Reorder some test's decorators (GH-108804) (#108844)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 4 Sep 2023 11:47:07 +0000 (04:47 -0700)
committerGitHub <noreply@github.com>
Mon, 4 Sep 2023 11:47:07 +0000 (13:47 +0200)
Reorder some test's decorators (GH-108804)

For example, do not demand the 'cpu' resource if the test cannot be run
due to non-working threads.
(cherry picked from commit 509bb61977cc8a4487efd3f9cdd63d9f7b86be62)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Lib/test/test_io.py
Lib/test/test_site.py

index cc16804fe2182921c699573a54778afefb8a86fe..fc56c1d51113511fd8bd4413ab31a94c67acea25 100644 (file)
@@ -1548,8 +1548,8 @@ class BufferedReaderTest(unittest.TestCase, CommonBufferedTests):
 
         self.assertEqual(b"abcdefg", bufio.read())
 
-    @support.requires_resource('cpu')
     @threading_helper.requires_working_threading()
+    @support.requires_resource('cpu')
     def test_threads(self):
         try:
             # Write out many bytes with exactly the same number of 0's,
@@ -1937,8 +1937,8 @@ class BufferedWriterTest(unittest.TestCase, CommonBufferedTests):
                 f.truncate()
                 self.assertEqual(f.tell(), buffer_size + 2)
 
-    @support.requires_resource('cpu')
     @threading_helper.requires_working_threading()
+    @support.requires_resource('cpu')
     def test_threads(self):
         try:
             # Write out many bytes from many threads and test they were
index 9e701fd847acdf9fad35db944d3fd50169d195bf..20a96169e8be4eb5e09026e31b684578f15f4077 100644 (file)
@@ -465,10 +465,10 @@ class ImportSideEffectTests(unittest.TestCase):
             else:
                 self.fail("sitecustomize not imported automatically")
 
-    @test.support.requires_resource('network')
-    @test.support.system_must_validate_cert
     @unittest.skipUnless(hasattr(urllib.request, "HTTPSHandler"),
                          'need SSL support to download license')
+    @test.support.requires_resource('network')
+    @test.support.system_must_validate_cert
     def test_license_exists_at_url(self):
         # This test is a bit fragile since it depends on the format of the
         # string displayed by license in the absence of a LICENSE file.