]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath12k: Refactor RX TID deletion handling into helper function
authorNithyanantham Paramasivam <nithyanantham.paramasivam@oss.qualcomm.com>
Wed, 6 Aug 2025 11:17:45 +0000 (16:47 +0530)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Mon, 22 Sep 2025 20:41:44 +0000 (13:41 -0700)
Refactor RX TID deletion handling by moving the REO command
setup and send sequence into a new helper function:
ath12k_dp_rx_tid_delete_handler().

This improves code readability and modularity, and prepares
the codebase for potential reuse of the REO command logic in
other contexts where RX TID deletion is required.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Nithyanantham Paramasivam <nithyanantham.paramasivam@oss.qualcomm.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250806111750.3214584-3-nithyanantham.paramasivam@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/dp_rx.c

index adb0cfe109e673d405cb07366100701387fc1c68..8c61c7f3bbdc9bb8e81a4e3801fd71c25a726619 100644 (file)
@@ -21,6 +21,9 @@
 
 #define ATH12K_DP_RX_FRAGMENT_TIMEOUT_MS (2 * HZ)
 
+static int ath12k_dp_rx_tid_delete_handler(struct ath12k_base *ab,
+                                            struct ath12k_dp_rx_tid *rx_tid);
+
 static enum hal_encrypt_type ath12k_dp_rx_h_enctype(struct ath12k_base *ab,
                                                    struct hal_rx_desc *desc)
 {
@@ -769,6 +772,21 @@ free_desc:
        rx_tid->qbuf.vaddr = NULL;
 }
 
+static int ath12k_dp_rx_tid_delete_handler(struct ath12k_base *ab,
+                                            struct ath12k_dp_rx_tid *rx_tid)
+{
+       struct ath12k_hal_reo_cmd cmd = {};
+
+       cmd.flag = HAL_REO_CMD_FLG_NEED_STATUS;
+       cmd.addr_lo = lower_32_bits(rx_tid->qbuf.paddr_aligned);
+       cmd.addr_hi = upper_32_bits(rx_tid->qbuf.paddr_aligned);
+       cmd.upd0 |= HAL_REO_CMD_UPD0_VLD;
+
+       return ath12k_dp_reo_cmd_send(ab, rx_tid,
+                                     HAL_REO_CMD_UPDATE_RX_QUEUE, &cmd,
+                                     ath12k_dp_rx_tid_del_func);
+}
+
 static void ath12k_peer_rx_tid_qref_setup(struct ath12k_base *ab, u16 peer_id, u16 tid,
                                          dma_addr_t paddr)
 {
@@ -828,20 +846,13 @@ static void ath12k_peer_rx_tid_qref_reset(struct ath12k_base *ab, u16 peer_id, u
 void ath12k_dp_rx_peer_tid_delete(struct ath12k *ar,
                                  struct ath12k_peer *peer, u8 tid)
 {
-       struct ath12k_hal_reo_cmd cmd = {};
        struct ath12k_dp_rx_tid *rx_tid = &peer->rx_tid[tid];
        int ret;
 
        if (!rx_tid->active)
                return;
 
-       cmd.flag = HAL_REO_CMD_FLG_NEED_STATUS;
-       cmd.addr_lo = lower_32_bits(rx_tid->qbuf.paddr_aligned);
-       cmd.addr_hi = upper_32_bits(rx_tid->qbuf.paddr_aligned);
-       cmd.upd0 = HAL_REO_CMD_UPD0_VLD;
-       ret = ath12k_dp_reo_cmd_send(ar->ab, rx_tid,
-                                    HAL_REO_CMD_UPDATE_RX_QUEUE, &cmd,
-                                    ath12k_dp_rx_tid_del_func);
+       ret = ath12k_dp_rx_tid_delete_handler(ar->ab, rx_tid);
        if (ret) {
                ath12k_err(ar->ab, "failed to send HAL_REO_CMD_UPDATE_RX_QUEUE cmd, tid %d (%d)\n",
                           tid, ret);