]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4-dsdb:large_ldap: Note that we don't check that an error was raised
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 7 Mar 2023 00:43:25 +0000 (13:43 +1300)
committerAndreas Schneider <asn@cryptomilk.org>
Wed, 12 Apr 2023 13:52:31 +0000 (13:52 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/dsdb/tests/python/large_ldap.py

index 8ebb478a9457a1ce14458af2f074c48adafcf127..cefeaa3f89fa1d85110350063aa4e0e3dbf486d6 100644 (file)
@@ -196,6 +196,14 @@ class LargeLDAPTest(samba.tests.TestCase):
         except LdbError as err:
             enum = err.args[0]
             self.assertEqual(enum, ldb.ERR_SIZE_LIMIT_EXCEEDED)
+        else:
+            # FIXME: Due to a bug in the client, the second exception to
+            # transmit the iteration error isn't raised. We must still check
+            # that the number of results is fewer than the total count.
+
+            # self.fail('expected to fail with ERR_SIZE_LIMIT_EXCEEDED')
+
+            pass
 
         # Assert we don't get all the entries but still the error
         self.assertGreater(count, count_jpeg)
@@ -256,6 +264,14 @@ class LargeLDAPTest(samba.tests.TestCase):
         except LdbError as err:
             enum = err.args[0]
             self.assertEqual(enum, ldb.ERR_SIZE_LIMIT_EXCEEDED)
+        else:
+            # FIXME: Due to a bug in the client, the second exception to
+            # transmit the iteration error isn't raised. We must still check
+            # that the number of results is fewer than the total count.
+
+            # self.fail('expected to fail with ERR_SIZE_LIMIT_EXCEEDED')
+
+            pass
 
         # Assert we don't get all the entries but still the error
         self.assertGreater(count, count_jpeg)