]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: dsa: realtek: rtl8365mb: fix rtl8365mb_phy_ocp_write return value
authorMieczyslaw Nalewaj <namiltd@yahoo.com>
Sun, 1 Mar 2026 21:13:14 +0000 (18:13 -0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 3 Mar 2026 02:32:40 +0000 (18:32 -0800)
Function rtl8365mb_phy_ocp_write() always returns 0, even when an error
occurs during register access. This patch fixes the return value to
propagate the actual error code from regmap operations.

Link: https://lore.kernel.org/netdev/a2dfde3c-d46f-434b-9d16-1e251e449068@yahoo.com/
Fixes: 2796728460b8 ("net: dsa: realtek: rtl8365mb: serialize indirect PHY register access")
Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260301-realtek_namiltd_fix1-v1-1-43a6bb707f9c@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/realtek/rtl8365mb.c

index c575e164368c84f1bbbd29a38d12c9a1dc26856f..f938a3f701cc955b07c45a6eeceed8bb17bc4178 100644 (file)
@@ -769,7 +769,7 @@ static int rtl8365mb_phy_ocp_write(struct realtek_priv *priv, int phy,
 out:
        rtl83xx_unlock(priv);
 
-       return 0;
+       return ret;
 }
 
 static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum)