Security/tcptls: MitM Attack potential from certificate with NULL byte in CN.

When registering to a SIP server with TLS, Asterisk will accept CA signed
certificates with a common name that was signed for a domain other than the
one requested if it contains a null character in the common name portion of
the cert. This patch fixes that by checking that the common name length
matches the the length of the content we actually read from the common name
segment. Some certificate authorities automatically sign CA requests when
the requesting CN isn't already taken, so an attacker could potentially
register a CN with something like www.google.com\x00www.secretlyevil.net
and have their certificate signed and Asterisk would accept that certificate
as though it had been for www.google.com - this is a security fix and is
noted in AST-2015-003.

ASTERISK-24847 #close
Reported by: Maciej Szmigiero
Patches:
 asterisk-null-in-cn.patch submitted by mhej (license 6085)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@434337 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/main/tcptls.c b/main/tcptls.c
index 0c6b44ec3011790a17c28f2577001237bca32cba..a5a2af60f58b3db94f15f80ca88c3be85bc6df42 100644 (file)
--- a/main/tcptls.c
+++ b/main/tcptls.c
@@ -638,10 +638,17 @@ static void *handle_tcptls_connection(void *data)
                                                if (pos < 0)
                                                        break;
                                                str = X509_NAME_ENTRY_get_data(X509_NAME_get_entry(name, pos));
-                                               ASN1_STRING_to_UTF8(&str2, str);
+                                               ret = ASN1_STRING_to_UTF8(&str2, str);
+                                               if (ret < 0) {
+                                                       continue;
+                                               }
+
                                                if (str2) {
-                                                       if (!strcasecmp(tcptls_session->parent->hostname, (char *) str2))
+                                                       if (strlen((char *) str2) != ret) {
+                                                               ast_log(LOG_WARNING, "Invalid certificate common name length (contains NULL bytes?)\n");
+                                                       } else if (!strcasecmp(tcptls_session->parent->hostname, (char *) str2)) {
                                                                found = 1;
+                                                       }
                                                        ast_debug(3, "SSL Common Name compare s1='%s' s2='%s'\n", tcptls_session->parent->hostname, str2);
                                                        OPENSSL_free(str2);
                                                }