]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
libssh2: part of conditional expression is always true: !result
authorDaniel Stenberg <daniel@haxx.se>
Thu, 19 Sep 2019 08:25:15 +0000 (10:25 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Fri, 20 Sep 2019 06:07:52 +0000 (08:07 +0200)
Fixes warning detected by PVS-Studio
Fixes #4374

lib/vssh/libssh2.c

index 2b25a514f453926bee903c211eb10815ac4a145d..6a6793aa3fda6511f49e2d53e0857225df183d3f 100644 (file)
@@ -2811,7 +2811,7 @@ static CURLcode ssh_block_statemach(struct connectdata *conn,
     }
 
 #ifdef HAVE_LIBSSH2_SESSION_BLOCK_DIRECTION
-    if(!result && block) {
+    if(block) {
       int dir = libssh2_session_block_directions(sshc->ssh_session);
       curl_socket_t sock = conn->sock[FIRSTSOCKET];
       curl_socket_t fd_read = CURL_SOCKET_BAD;