]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
seccomp: move sched_getaffinity() from @system-service to @default 20318/head
authorLennart Poettering <lennart@poettering.net>
Tue, 27 Jul 2021 15:11:09 +0000 (17:11 +0200)
committerLennart Poettering <lennart@poettering.net>
Tue, 27 Jul 2021 15:14:06 +0000 (17:14 +0200)
See: https://github.com/systemd/systemd/pull/20191#issuecomment-881982739

In general, we shouldn't blanket move syscalls like this into @default,
given that glibc actually does have fallbacks, afaics. However, as
long as the syscalls are "read-only" and thus benign, I figure it's a
safe thing to do. But we should probably stick to a "if in doubt, don't"
rule, and put these syscalls in @system-service as default, but not into
@default.

I think in the real world @system-service is the sensible group people
should use, and not @default actually.

src/shared/seccomp-util.c

index 703d5a939ced429b29ac1512e8db8694d9d1fabd..631ca5dd34eb4c1168a89ade5942410bda21227e 100644 (file)
@@ -331,6 +331,7 @@ const SyscallFilterSet syscall_filter_sets[_SYSCALL_FILTER_SET_MAX] = {
                 "restart_syscall\0"
                 "rseq\0"
                 "rt_sigreturn\0"
+                "sched_getaffinity\0"
                 "sched_yield\0"
                 "set_robust_list\0"
                 "set_thread_area\0"
@@ -874,7 +875,6 @@ const SyscallFilterSet syscall_filter_sets[_SYSCALL_FILTER_SET_MAX] = {
                 "remap_file_pages\0"
                 "sched_get_priority_max\0"
                 "sched_get_priority_min\0"
-                "sched_getaffinity\0"
                 "sched_getattr\0"
                 "sched_getparam\0"
                 "sched_getscheduler\0"