vacuumdb: Fix --missing-stats-only for partitioned indexes.

The current form of the catalog query picks up partitioned tables
with expression indexes that lack statistics.  However, since such
indexes never have statistics, there's no point in analyzing them.
To fix, adjust the relevant part of the query to skip partitioned
tables with expression indexes.  While at it, remove the nearby
stainherit check; entries for index expressions always have
stainherit = false.

Author: Baji Shaik <baji.pgdev@gmail.com>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/CA%2Bfm-RPE1tEc6CUUPDyRbYTz9tF5Kw47nnk-Zq%3DyYvanbsxyCQ%40mail.gmail.com
Backpatch-through: 18

diff --git a/src/bin/scripts/t/100_vacuumdb.pl b/src/bin/scripts/t/100_vacuumdb.pl
index ef2faf610b60be5580ed31f5e38ba0842ea84cbd..d8b89fc899cb1776ea153a4742601da4230e4f76 100644 (file)
--- a/src/bin/scripts/t/100_vacuumdb.pl
+++ b/src/bin/scripts/t/100_vacuumdb.pl
@@ -322,6 +322,7 @@ $node->issues_sql_unlike(
 $node->safe_psql('postgres',
        "CREATE TABLE regression_vacuumdb_parted (a INT) PARTITION BY LIST (a);\n"
          . "CREATE TABLE regression_vacuumdb_part1 PARTITION OF regression_vacuumdb_parted FOR VALUES IN (1);\n"
+         . "CREATE INDEX ON regression_vacuumdb_parted ((a + 1));\n"
          . "INSERT INTO regression_vacuumdb_parted VALUES (1);\n"
          . "ANALYZE regression_vacuumdb_part1;\n");
 $node->issues_sql_like(

diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
index e97ace18104e5ff9f2892ad3201fd5fdbf0d4aed..fa04109f2d784535e48da8204b09bc5da278832f 100644 (file)
--- a/src/bin/scripts/vacuumdb.c
+++ b/src/bin/scripts/vacuumdb.c
@@ -985,10 +985,10 @@ retrieve_objects(PGconn *conn, vacuumingOptions *vacopts,
                                                         " AND a.attnum OPERATOR(pg_catalog.>) 0::pg_catalog.int2\n"
                                                         " AND NOT a.attisdropped\n"
                                                         " AND a.attstattarget IS DISTINCT FROM 0::pg_catalog.int2\n"
+                                                        " AND NOT p.inherited\n"
                                                         " AND NOT EXISTS (SELECT NULL FROM pg_catalog.pg_statistic s\n"
                                                         " WHERE s.starelid OPERATOR(pg_catalog.=) a.attrelid\n"
-                                                        " AND s.staattnum OPERATOR(pg_catalog.=) a.attnum\n"
-                                                        " AND s.stainherit OPERATOR(pg_catalog.=) p.inherited))\n");
+                                                        " AND s.staattnum OPERATOR(pg_catalog.=) a.attnum))\n");
 
                /* inheritance and regular stats */
                appendPQExpBufferStr(&catalog_query,