]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
neighbour: fix unaligned access to pneigh_entry
authorQingfang DENG <qingfang.deng@siflower.com.cn>
Thu, 1 Jun 2023 01:54:32 +0000 (09:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jun 2023 08:59:55 +0000 (10:59 +0200)
[ Upstream commit ed779fe4c9b5a20b4ab4fd6f3e19807445bb78c7 ]

After the blamed commit, the member key is longer 4-byte aligned. On
platforms that do not support unaligned access, e.g., MIPS32R2 with
unaligned_action set to 1, this will trigger a crash when accessing
an IPv6 pneigh_entry, as the key is cast to an in6_addr pointer.

Change the type of the key to u32 to make it aligned.

Fixes: 62dd93181aaa ("[IPV6] NDISC: Set per-entry is_router flag in Proxy NA.")
Signed-off-by: Qingfang DENG <qingfang.deng@siflower.com.cn>
Link: https://lore.kernel.org/r/20230601015432.159066-1-dqfext@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/net/neighbour.h

index 729bdf710b7e0d45ae373da4b4841612628f6dff..e595e944ebfc08dd180821e17e3518c661a0f4f1 100644 (file)
@@ -174,7 +174,7 @@ struct pneigh_entry {
        struct net_device       *dev;
        u8                      flags;
        u8                      protocol;
-       u                     key[];
+       u32                     key[];
 };
 
 /*