fs-posix: Fix fs_copy() potentially doing unnecessary unlink()

We need to check if link() failed before checking errno.

diff --git a/src/lib-fs/fs-posix.c b/src/lib-fs/fs-posix.c
index 4097151bb5cfd9bd7ee9a13abc4112424d02ac79..7b2ba2f47682d981272d7c41a9b06e1b423e232c 100644 (file)
--- a/src/lib-fs/fs-posix.c
+++ b/src/lib-fs/fs-posix.c
@@ -836,7 +836,8 @@ static int fs_posix_copy(struct fs_file *_src, struct fs_file *_dest)
 
        fs_posix_write_rename_if_needed(dest);
        ret = link(src->full_path, dest->full_path);
-       if (errno == EEXIST && dest->open_mode == FS_OPEN_MODE_REPLACE) {
+       if (ret < 0 && errno == EEXIST &&
+           dest->open_mode == FS_OPEN_MODE_REPLACE) {
                /* destination file already exists - replace it */
                i_unlink_if_exists(dest->full_path);
                ret = link(src->full_path, dest->full_path);