]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests: rtnetlink.sh: remove esp4_offload after test
authorXiumei Mu <xmu@redhat.com>
Fri, 25 Jul 2025 03:50:28 +0000 (11:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:22:33 +0000 (16:22 +0200)
[ Upstream commit 5b32321fdaf3fd1a92ec726af18765e225b0ee2b ]

The esp4_offload module, loaded during IPsec offload tests, should
be reset to its default settings after testing.
Otherwise, leaving it enabled could unintentionally affect subsequence
test cases by keeping offload active.

Without this fix:
$ lsmod | grep offload; ./rtnetlink.sh -t kci_test_ipsec_offload ; lsmod | grep offload;
PASS: ipsec_offload
esp4_offload           12288  0
esp4                   32768  1 esp4_offload

With this fix:
$ lsmod | grep offload; ./rtnetlink.sh -t kci_test_ipsec_offload ; lsmod | grep offload;
PASS: ipsec_offload

Fixes: 2766a11161cc ("selftests: rtnetlink: add ipsec offload API test")
Signed-off-by: Xiumei Mu <xmu@redhat.com>
Reviewed-by: Shannon Nelson <sln@onemain.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://patch.msgid.link/6d3a1d777c4de4eb0ca94ced9e77be8d48c5b12f.1753415428.git.xmu@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/net/rtnetlink.sh

index a3597b3e579fed3753a57e07918b334a4082b73d..0a6212a964155dae8d5b1f5d5074ce6e582f3cc1 100755 (executable)
@@ -746,6 +746,11 @@ kci_test_ipsec_offload()
        sysfsf=$sysfsd/ipsec
        sysfsnet=/sys/bus/netdevsim/devices/netdevsim0/net/
        probed=false
+       esp4_offload_probed_default=false
+
+       if lsmod | grep -q esp4_offload; then
+               esp4_offload_probed_default=true
+       fi
 
        # setup netdevsim since dummydev doesn't have offload support
        if [ ! -w /sys/bus/netdevsim/new_device ] ; then
@@ -835,6 +840,7 @@ EOF
        fi
 
        # clean up any leftovers
+       ! "$esp4_offload_probed_default" && lsmod | grep -q esp4_offload && rmmod esp4_offload
        echo 0 > /sys/bus/netdevsim/del_device
        $probed && rmmod netdevsim