[#4256] Addressed more comments

changelog_unreleased/4256-3-1-4-dhcpv6-client-classes-logical-expressions-in-ifelse-do-not-work
src/lib/dhcpsrv/tests/client_class_def_unittest.cc

diff --git a/changelog_unreleased/4256-3-1-4-dhcpv6-client-classes-logical-expressions-in-ifelse-do-not-work b/changelog_unreleased/4256-3-1-4-dhcpv6-client-classes-logical-expressions-in-ifelse-do-not-work
index d1c447ac84f367371e041a5848993ddb80ace869..05208675216e316fb165c9f9ff0e5382487a23d3 100644 (file)
--- a/changelog_unreleased/4256-3-1-4-dhcpv6-client-classes-logical-expressions-in-ifelse-do-not-work
+++ b/changelog_unreleased/4256-3-1-4-dhcpv6-client-classes-logical-expressions-in-ifelse-do-not-work
@@ -1,4 +1,4 @@
 [func]         tmark
        Template classes template-test expressions may
-       now test for membership in 'KNOWN'
+       now test for membership in 'KNOWN'/'UNKNOW'.
        (Gitlab #4256)

diff --git a/src/lib/dhcpsrv/tests/client_class_def_unittest.cc b/src/lib/dhcpsrv/tests/client_class_def_unittest.cc
index 08546a43ff3b72b8f7e9b4d3143be752a685f9f3..cf1436f1556f486c1bef4e62e3aad2c8aec9ddc0 100644 (file)
--- a/src/lib/dhcpsrv/tests/client_class_def_unittest.cc
+++ b/src/lib/dhcpsrv/tests/client_class_def_unittest.cc
@@ -1683,7 +1683,7 @@ TEST(ClientClassDictionary, templateClassDependOnKnown) {
     std::string config_txt = R"^([
         {
             "name": "does_not",
-            "template-test": "hexstring(substring(option[1].hex,0,4))"
+            "template-test": "hexstring(substring(option[1].hex, 0, 4), '')"
         },
         {
             "name": "does",