]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: cdns3: gadget: fix NULL pointer dereference in ep_queue
authorYongchao Wu <yongchao.wu@autochips.com>
Tue, 31 Mar 2026 00:04:07 +0000 (08:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 07:30:25 +0000 (09:30 +0200)
When the gadget endpoint is disabled or not yet configured, the ep->desc
pointer can be NULL. This leads to a NULL pointer dereference when
__cdns3_gadget_ep_queue() is called, causing a kernel crash.

Add a check to return -ESHUTDOWN if ep->desc is NULL, which is the
standard return code for unconfigured endpoints.

This prevents potential crashes when ep_queue is called on endpoints
that are not ready.

Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Cc: stable <stable@kernel.org>
Signed-off-by: Yongchao Wu <yongchao.wu@autochips.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Link: https://patch.msgid.link/20260331000407.613298-1-yongchao.wu@autochips.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdns3-gadget.c

index d59a60a16ec77009da0869a2955aae1c6ddc7c69..96d2a4c38b3f4b0088e6b4bcf0ed986110ae9210 100644 (file)
@@ -2589,6 +2589,9 @@ static int __cdns3_gadget_ep_queue(struct usb_ep *ep,
        struct cdns3_request *priv_req;
        int ret = 0;
 
+       if (!ep->desc)
+               return -ESHUTDOWN;
+
        request->actual = 0;
        request->status = -EINPROGRESS;
        priv_req = to_cdns3_request(request);