Issue #12946: Remove dead code in PyModule_GetDict

PyModule_NewObject already sets md_dict to PyDict_New():

    m->md_dict = PyDict_New();

diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
index a4cdc206c12a69045ede2db7a338063940256cc9..fb568f531d5e5a312bcf5ec59f3cb2e7bdc7e2fb 100644 (file)
--- a/Objects/moduleobject.c
+++ b/Objects/moduleobject.c
@@ -444,8 +444,7 @@ PyModule_GetDict(PyObject *m)
         return NULL;
     }
     d = ((PyModuleObject *)m) -> md_dict;
-    if (d == NULL)
-        ((PyModuleObject *)m) -> md_dict = d = PyDict_New();
+    assert(d != NULL);
     return d;
 }