]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
delta: use r for storing error code
authorYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 24 Jan 2025 13:46:35 +0000 (22:46 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 24 Jan 2025 13:46:35 +0000 (22:46 +0900)
src/delta/delta.c

index c7cf6c9b0bb171aedfb016070680159755a2c824..e93b2ba6199004fad6b7ff307f6cb26b6a4c5fc0 100644 (file)
@@ -226,7 +226,6 @@ static int enumerate_dir_d(
 
         STRV_FOREACH(file, list) {
                 OrderedHashmap *h;
-                int k;
                 char *p;
                 char *d;
 
@@ -239,23 +238,23 @@ static int enumerate_dir_d(
                 d = p + strlen(toppath) + 1;
 
                 log_debug("Adding at top: %s %s %s", d, special_glyph(SPECIAL_GLYPH_ARROW_RIGHT), p);
-                k = ordered_hashmap_ensure_put(top, &string_hash_ops_value_free, d, p);
-                if (k >= 0) {
+                r = ordered_hashmap_ensure_put(top, &string_hash_ops_value_free, d, p);
+                if (r >= 0) {
                         p = strdup(p);
                         if (!p)
                                 return -ENOMEM;
                         d = p + strlen(toppath) + 1;
-                } else if (k != -EEXIST) {
+                } else if (r != -EEXIST) {
                         free(p);
-                        return k;
+                        return r;
                 }
 
                 log_debug("Adding at bottom: %s %s %s", d, special_glyph(SPECIAL_GLYPH_ARROW_RIGHT), p);
                 free(ordered_hashmap_remove(*bottom, d));
-                k = ordered_hashmap_ensure_put(bottom, &string_hash_ops_value_free, d, p);
-                if (k < 0) {
+                r = ordered_hashmap_ensure_put(bottom, &string_hash_ops_value_free, d, p);
+                if (r < 0) {
                         free(p);
-                        return k;
+                        return r;
                 }
 
                 h = ordered_hashmap_get(*drops, unit);
@@ -275,11 +274,11 @@ static int enumerate_dir_d(
 
                 log_debug("Adding to drops: %s %s %s %s %s",
                           unit, special_glyph(SPECIAL_GLYPH_ARROW_RIGHT), basename(p), special_glyph(SPECIAL_GLYPH_ARROW_RIGHT), p);
-                k = ordered_hashmap_put(h, basename(p), p);
-                if (k < 0) {
+                r = ordered_hashmap_put(h, basename(p), p);
+                if (r < 0) {
                         free(p);
-                        if (k != -EEXIST)
-                                return k;
+                        if (r != -EEXIST)
+                                return r;
                 }
         }
         return 0;