Absolutely never call close_temp_logs while validating log options.

svn:r2934

diff --git a/src/or/config.c b/src/or/config.c
index cc5760f309e131f0c21e350a217beb9875e8177b..5a7d7158ec0070cbf70df77094c1accdfab4d67d 100644 (file)
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -1785,13 +1785,15 @@ config_init_logs(or_options_t *options, int validate_only)
       ok = 0; goto cleanup;
     }
     if (!strcasecmp(smartlist_get(elts,1), "stdout")) {
-      if (!validate_only)
+      if (!validate_only) {
         add_stream_log(levelMin, levelMax, "<stdout>", stdout);
-      close_temp_logs();
+        close_temp_logs();
+      }
     } else if (!strcasecmp(smartlist_get(elts,1), "stderr")) {
-      if (!validate_only)
+      if (!validate_only) {
         add_stream_log(levelMin, levelMax, "<stderr>", stderr);
-      close_temp_logs();
+        close_temp_logs();
+      }
     } else if (!strcasecmp(smartlist_get(elts,1), "syslog")) {
 #ifdef HAVE_SYSLOG_H
       if (!validate_only)