config: Set flag for implicit port address

Fun bug where we thought we were using the default "false" value when an
implicit address was detected but if we had an explicit address before, the
flag was set to true and then we would only use that value.

And thus, for some configurations, implicit addresses would be flagged as
explicit and then configuring ports goes bad.

Related to #40289

Signed-off-by: David Goulet <dgoulet@torproject.org>

diff --git a/src/app/config/config.c b/src/app/config/config.c
index c7799ec1a2b780db2f210444ac685a3c4a469eae..fa74907b3d6ebf01bc1e26c6fa35f846615eac7d 100644 (file)
--- a/src/app/config/config.c
+++ b/src/app/config/config.c
@@ -6034,6 +6034,7 @@ port_parse_config(smartlist_t *out,
       port = (int) tor_parse_long(addrport, 10, 0, 65535, &ok, NULL);
       if (ok) {
         tor_addr_copy(&addr, &default_addr);
+        addr_is_explicit = false;
       } else if (tor_addr_port_lookup(addrport, &addr, &ptmp) == 0) {
         if (ptmp == 0) {
           log_warn(LD_CONFIG, "%sPort line has address but no port", portname);