Pass precision value to mssql.DATETIME2 when it is 0

The simple check on the precision results in DATETIME2(0) generating a
DATETIME2 column, with default precision, which is 7.

diff --git a/lib/sqlalchemy/dialects/mssql/base.py b/lib/sqlalchemy/dialects/mssql/base.py
index 37e798014c95ea4c09decea4e2b8072dbe02588b..9e39ca9f28d1d50ae7c4e48694105a320110bb66 100644 (file)
--- a/lib/sqlalchemy/dialects/mssql/base.py
+++ b/lib/sqlalchemy/dialects/mssql/base.py
@@ -773,7 +773,7 @@ class MSTypeCompiler(compiler.GenericTypeCompiler):
 
     def visit_DATETIME2(self, type_, **kw):
         precision = getattr(type_, 'precision', None)
-        if precision:
+        if precision is not None:
             return "DATETIME2(%s)" % precision
         else:
             return "DATETIME2"

diff --git a/test/dialect/mssql/test_types.py b/test/dialect/mssql/test_types.py
index e782bd5e595b7a54ba2f100b213926b0bbb7d72f..d8a82630b80f961ecc187a904f98a1bd7db86bd3 100644 (file)
--- a/test/dialect/mssql/test_types.py
+++ b/test/dialect/mssql/test_types.py
@@ -464,6 +464,8 @@ class TypeRoundTripTest(
 
             (mssql.MSDateTime2, [], {},
              'DATETIME2', ['>=', (10,)]),
+            (mssql.MSDateTime2, [0], {},
+             'DATETIME2(0)', ['>=', (10,)]),
             (mssql.MSDateTime2, [1], {},
              'DATETIME2(1)', ['>=', (10,)]),