]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
clarified an argument's situation due to a false positive alert pointed out
authorDaniel Stenberg <daniel@haxx.se>
Sun, 19 Oct 2008 18:20:47 +0000 (18:20 +0000)
committerDaniel Stenberg <daniel@haxx.se>
Sun, 19 Oct 2008 18:20:47 +0000 (18:20 +0000)
by coverity.com

lib/url.c

index 45567b6a0ad6c67167fd41e3d1ba082c25847147..040a64cd1495a1097bb434d8ae2df8f4529d477b 100644 (file)
--- a/lib/url.c
+++ b/lib/url.c
@@ -4355,8 +4355,8 @@ static CURLcode create_conn(struct SessionHandle *data,
  */
 
 static CURLcode setup_conn(struct connectdata *conn,
-                                struct Curl_dns_entry *hostaddr,
-                                bool *protocol_done)
+                           struct Curl_dns_entry *hostaddr,
+                           bool *protocol_done)
 {
   CURLcode result=CURLE_OK;
   struct SessionHandle *data = conn->data;
@@ -4402,7 +4402,12 @@ static CURLcode setup_conn(struct connectdata *conn,
     if(CURL_SOCKET_BAD == conn->sock[FIRSTSOCKET]) {
       bool connected = FALSE;
 
-      /* Connect only if not already connected! */
+      /* Connect only if not already connected!
+       *
+       * NOTE: hostaddr can be NULL when passed to this function, but that is
+       * only for the case where we re-use an existing connection and thus
+       * this code section will not be reached with hostaddr == NULL.
+       */
       result = ConnectPlease(data, conn, hostaddr, &connected);
 
       if(connected) {