]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Asterisk crashing because of double free when EWS request fails
authorJan Kalab <pitlicek@gmail.com>
Fri, 17 Sep 2010 08:42:37 +0000 (08:42 +0000)
committerJan Kalab <pitlicek@gmail.com>
Fri, 17 Sep 2010 08:42:37 +0000 (08:42 +0000)
The free is done later in code. I think ast_free() should have built in checks for double free.

(closes issue #17782)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@287270 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_calendar_ews.c

index 4932423055b5731862a24be34b597c5e907cd809..27a4bf9f6ea57174f3f5f4c3ee57b06b1f070c18 100644 (file)
@@ -528,7 +528,6 @@ static int send_ews_request_and_parse(struct ast_str *request, struct xml_contex
        if (ret != NE_OK) { /* Error handling */
                ast_log(LOG_WARNING, "Unable to communicate with Exchange Web Service at '%s': %s\n", ctx->pvt->url, ne_get_error(ctx->pvt->session));
                ne_request_destroy(req);
-               ast_free(request);
                ne_xml_destroy(parser);
                return -1;
        }