]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pytest:segfault: avoid gdb_backtrace on knownfail
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 11 Feb 2021 09:16:33 +0000 (22:16 +1300)
committerDavid Mulder <dmulder@samba.org>
Mon, 22 Feb 2021 14:45:38 +0000 (14:45 +0000)
We know that test_net_replicate_init__3() segfaults. It is a knownfail
and we don't need to see the gdb backtrace every time.

This saves nearly two minutes on `make test TESTS=segfault`.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: David Mulder <dmulder@suse.com>
python/samba/tests/segfault.py

index 07e2d46d56ad618e014bbf3b62f4985e3765aa37..40ba4aa148af3f6909705a308d4ad9cf794aa4b7 100644 (file)
@@ -57,6 +57,16 @@ def segfault_detector(f):
     return wrapper
 
 
+def no_gdb_backtrace(f):
+    from os import environ
+    def w(*args, **kwargs):
+        environ['PLEASE_NO_GDB_BACKTRACE'] = '1'
+        f(*args, **kwargs)
+        del environ['PLEASE_NO_GDB_BACKTRACE']
+
+    return w
+
+
 class SegfaultTests(samba.tests.TestCase):
     def get_lp_et_al(self):
         server = os.environ["SERVER"]
@@ -78,6 +88,7 @@ class SegfaultTests(samba.tests.TestCase):
         net = Net(creds, lp, server=server)
         net.replicate_init(42, lp, None, misc.GUID())
 
+    @no_gdb_backtrace
     @segfault_detector
     def test_net_replicate_init__3(self):
         # third argument is also unchecked