]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
serial: Fix potential null-ptr-deref in mlb_usio_probe()
authorHenry Martin <bsdhenrymartin@gmail.com>
Thu, 3 Apr 2025 07:03:39 +0000 (15:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:04:06 +0000 (11:04 +0100)
[ Upstream commit 86bcae88c9209e334b2f8c252f4cc66beb261886 ]

devm_ioremap() can return NULL on error. Currently, mlb_usio_probe()
does not check for this case, which could result in a NULL pointer
dereference.

Add NULL check after devm_ioremap() to prevent this issue.

Fixes: ba44dc043004 ("serial: Add Milbeaut serial control")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
Link: https://lore.kernel.org/r/20250403070339.64990-1-bsdhenrymartin@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/serial/milbeaut_usio.c

index 8f2cab7f66ad309d37cfa23fa4285ce01fb70879..d9f094514945b5572d1eaf80418ddb27cb0fcf5e 100644 (file)
@@ -523,7 +523,10 @@ static int mlb_usio_probe(struct platform_device *pdev)
        }
        port->membase = devm_ioremap(&pdev->dev, res->start,
                                resource_size(res));
-
+       if (!port->membase) {
+               ret = -ENOMEM;
+               goto failed;
+       }
        ret = platform_get_irq_byname(pdev, "rx");
        mlb_usio_irq[index][RX] = ret;