]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests/bpf: Fix timer_start_deadlock failure due to hrtimer change
authorShung-Hsi Yu <shung-hsi.yu@suse.com>
Wed, 15 Apr 2026 12:03:28 +0000 (20:03 +0800)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 15 Apr 2026 15:25:04 +0000 (08:25 -0700)
Since commit f2e388a019e4 ("hrtimer: Reduce trace noise in hrtimer_start()"),
hrtimer_cancel tracepoint is no longer called when a hrtimer is re-armed. So
instead of a hrtimer_cancel followed by hrtimer_start tracepoint events, there
is now only a since hrtimer_start tracepoint event with the new was_armed field
set to 1, to indicated that the hrtimer was previously armed.

Update timer_start_deadlock accordingly so it traces hrtimer_start tracepoint
instead, with was_armed used as guard.

Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Tested-by: Mykyta Yatsenko <yatsenko@meta.com>
Acked-by: Mykyta Yatsenko <yatsenko@meta.com>
Link: https://lore.kernel.org/r/20260415120329.129192-1-shung-hsi.yu@suse.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/progs/timer_start_deadlock.c

index 019518ee18cd5610657fc8509c33d45438890628..afabd15bdac41c4702c3875fed99172dc0951a38 100644 (file)
@@ -27,13 +27,13 @@ static int timer_cb(void *map, int *key, struct elem *value)
        return 0;
 }
 
-SEC("tp_btf/hrtimer_cancel")
-int BPF_PROG(tp_hrtimer_cancel, struct hrtimer *hrtimer)
+SEC("tp_btf/hrtimer_start")
+int BPF_PROG(tp_hrtimer_start, struct hrtimer *hrtimer, enum hrtimer_mode mode, bool was_armed)
 {
        struct bpf_timer *timer;
        int key = 0;
 
-       if (!in_timer_start)
+       if (!in_timer_start || !was_armed)
                return 0;
 
        tp_called = 1;
@@ -60,7 +60,7 @@ int start_timer(void *ctx)
 
        /*
         * call hrtimer_start() twice, so that 2nd call does
-        * remove_hrtimer() and trace_hrtimer_cancel() tracepoint.
+        * trace_hrtimer_start(was_armed=1) tracepoint.
         */
        in_timer_start = 1;
        bpf_timer_start(timer, 1000000000, 0);