]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amd/display: Initialize mode_select to 0
authorAlex Hung <alex.hung@amd.com>
Tue, 10 Jun 2025 21:40:18 +0000 (15:40 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Aug 2025 16:41:16 +0000 (18:41 +0200)
[ Upstream commit 592ddac93f8c02e13f19175745465f8c4d0f56cd ]

[WHAT]
mode_select was supposed to be initialized in mpc_read_gamut_remap but
is not set in default case. This can cause indeterminate
behaviors.

This is reported as an UNINIT error by Coverity.

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Fangzhi Zuo <jerry.zuo@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/display/dc/mpc/dcn401/dcn401_mpc.c

index 98cf0cbd59ba0ea05638e6724bbc55d6cdef2685..591af5a3d3e3ad75efabfe11c1c07afdda2332b7 100644 (file)
@@ -561,7 +561,7 @@ void mpc401_get_gamut_remap(struct mpc *mpc,
        struct mpc_grph_gamut_adjustment *adjust)
 {
        uint16_t arr_reg_val[12] = {0};
-       uint32_t mode_select;
+       uint32_t mode_select = MPCC_GAMUT_REMAP_MODE_SELECT_0;
 
        read_gamut_remap(mpc, mpcc_id, arr_reg_val, adjust->mpcc_gamut_remap_block_id, &mode_select);