]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
statmount: Fix the null-ptr-deref in do_statmount()
authorQing Wang <wangqing7171@gmail.com>
Fri, 13 Feb 2026 10:30:06 +0000 (18:30 +0800)
committerChristian Brauner <brauner@kernel.org>
Sat, 14 Feb 2026 12:17:50 +0000 (13:17 +0100)
If the mount is internal, it's mnt_ns will be MNT_NS_INTERNAL, which is
defined as ERR_PTR(-EINVAL). So, in the do_statmount(), need to check ns
of mount by IS_ERR() and return.

Fixes: 0e5032237ee5 ("statmount: accept fd as a parameter")
Reported-by: syzbot+9e03a9535ea65f687a44@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/698e287a.a70a0220.2c38d7.009e.GAE@google.com/
Signed-off-by: Qing Wang <wangqing7171@gmail.com>
Link: https://patch.msgid.link/20260213103006.2472569-1-wangqing7171@gmail.com
Reviewed-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/namespace.c

index a67cbe42746d514aaa94e8dccefa84217ed86ac7..90700df65f0de17a579df3b81c4d39f0eeaf8e60 100644 (file)
@@ -5678,6 +5678,8 @@ static int do_statmount(struct kstatmount *s, u64 mnt_id, u64 mnt_ns_id,
 
                s->mnt = mnt_file->f_path.mnt;
                ns = real_mount(s->mnt)->mnt_ns;
+               if (IS_ERR(ns))
+                       return PTR_ERR(ns);
                if (!ns)
                        /*
                         * We can't set mount point and mnt_ns_id since we don't have a