Fix segfault if starting qemu VM with an inactive virtual network.

diff --git a/ChangeLog b/ChangeLog
index 79e1dbe3f77846943e0fa883014dc542a1440298..e0b69a39e17c5bce727f016e3b2f429592c37c19 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Mon Oct  6 15:32:00 EST 2008 Cole Robinson <crobinso@redhat.com>
+
+       * src/qemu_conf.c: Fix possible segfault if starting a qemu guest with
+         with an inactive virtual network.
+
 Mon Oct  6 15:23:00 EST 2008 Cole Robinson <crobinso@redhat.com>
 
        * tests/domainschematest: Slim down schema test result output

diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index 23ef050e7527a901aac50e9c3aa1604527b16cc3..5c41f9a85c56bd14cab56ae029ce269049c74064 100644 (file)
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
@@ -1235,7 +1235,7 @@ int qemudBuildCommandLine(virConnectPtr conn,
  error:
     if (tapfds &&
         *tapfds) {
-        for (i = 0; ntapfds; i++)
+        for (i = 0; i < *ntapfds; i++)
             close((*tapfds)[i]);
         VIR_FREE(*tapfds);
         *ntapfds = 0;