]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.15-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2025 12:51:04 +0000 (13:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2025 12:51:04 +0000 (13:51 +0100)
added patches:
ceph-give-up-on-paths-longer-than-path_max.patch
series

queue-5.15/ceph-give-up-on-paths-longer-than-path_max.patch [new file with mode: 0644]
queue-5.15/series [new file with mode: 0644]

diff --git a/queue-5.15/ceph-give-up-on-paths-longer-than-path_max.patch b/queue-5.15/ceph-give-up-on-paths-longer-than-path_max.patch
new file mode 100644 (file)
index 0000000..4f358d9
--- /dev/null
@@ -0,0 +1,52 @@
+From 550f7ca98ee028a606aa75705a7e77b1bd11720f Mon Sep 17 00:00:00 2001
+From: Max Kellermann <max.kellermann@ionos.com>
+Date: Mon, 18 Nov 2024 23:28:28 +0100
+Subject: ceph: give up on paths longer than PATH_MAX
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Max Kellermann <max.kellermann@ionos.com>
+
+commit 550f7ca98ee028a606aa75705a7e77b1bd11720f upstream.
+
+If the full path to be built by ceph_mdsc_build_path() happens to be
+longer than PATH_MAX, then this function will enter an endless (retry)
+loop, effectively blocking the whole task.  Most of the machine
+becomes unusable, making this a very simple and effective DoS
+vulnerability.
+
+I cannot imagine why this retry was ever implemented, but it seems
+rather useless and harmful to me.  Let's remove it and fail with
+ENAMETOOLONG instead.
+
+Cc: stable@vger.kernel.org
+Reported-by: Dario Weißer <dario@cure53.de>
+Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
+Reviewed-by: Alex Markuze <amarkuze@redhat.com>
+Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
+[idryomov@gmail.com: backport to 6.1: pr_warn() is still in use]
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/ceph/mds_client.c |    9 ++++-----
+ 1 file changed, 4 insertions(+), 5 deletions(-)
+
+--- a/fs/ceph/mds_client.c
++++ b/fs/ceph/mds_client.c
+@@ -2432,12 +2432,11 @@ retry:
+       if (pos < 0) {
+               /*
+-               * A rename didn't occur, but somehow we didn't end up where
+-               * we thought we would. Throw a warning and try again.
++               * The path is longer than PATH_MAX and this function
++               * cannot ever succeed.  Creating paths that long is
++               * possible with Ceph, but Linux cannot use them.
+                */
+-              pr_warn("build_path did not end path lookup where "
+-                      "expected, pos is %d\n", pos);
+-              goto retry;
++              return ERR_PTR(-ENAMETOOLONG);
+       }
+       *pbase = base;
diff --git a/queue-5.15/series b/queue-5.15/series
new file mode 100644 (file)
index 0000000..daad144
--- /dev/null
@@ -0,0 +1 @@
+ceph-give-up-on-paths-longer-than-path_max.patch