]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.11] [3.12] gh-109181: Fix refleak in tb_get_lineno() (GH-111948) (#111951)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 10 Nov 2023 13:32:02 +0000 (14:32 +0100)
committerGitHub <noreply@github.com>
Fri, 10 Nov 2023 13:32:02 +0000 (13:32 +0000)
[3.12] gh-109181: Fix refleak in tb_get_lineno() (GH-111948)

PyFrame_GetCode() returns a strong reference.
(cherry picked from commit 4b0c875d91727440251a8427a80d8515e39d18cd)

Co-authored-by: Victor Stinner <vstinner@python.org>
Python/traceback.c

index 664a73fdfbaa31a5c121fa142830c0db8ae44cdc..722f007459dc3b47a1594884b815e7cd1cc607be 100644 (file)
@@ -115,7 +115,10 @@ static int
 tb_get_lineno(PyTracebackObject* tb) {
     PyFrameObject* frame = tb->tb_frame;
     assert(frame != NULL);
-    return PyCode_Addr2Line(PyFrame_GetCode(frame), tb->tb_lasti);
+    PyCodeObject *code = PyFrame_GetCode(frame);
+    int lineno = PyCode_Addr2Line(code, tb->tb_lasti);
+    Py_DECREF(code);
+    return lineno;
 }
 
 static PyObject *