]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: spi-fsl-dspi: Remove unused chip->void_write_data
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 4 Mar 2020 22:00:34 +0000 (00:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Jun 2023 13:44:10 +0000 (15:44 +0200)
[ Upstream commit 6d6af5796e5d9a88ae83c9c753023bba61deb18b ]

This variable has been present since the initial submission of the
driver, and held, for some reason, the value of zero, to be sent on the
wire in the case there wasn't any TX buffer for the current transfer.

Since quite a while now, however, it isn't doing anything at all.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20200304220044.11193-3-olteanv@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Stable-dep-of: c5c31fb71f16 ("spi: fsl-dspi: avoid SCK glitches with continuous transfers")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-fsl-dspi.c

index 3e0200618af304ce4e5c9405a4c3c947f75e87ed..51e17f0828646b57f35c3968f9da5fc1bbf09272 100644 (file)
 
 struct chip_data {
        u32                     ctar_val;
-       u16                     void_write_data;
 };
 
 enum dspi_trans_mode {
@@ -190,7 +189,6 @@ struct fsl_dspi {
        const void                              *tx;
        void                                    *rx;
        void                                    *rx_end;
-       u16                                     void_write_data;
        u16                                     tx_cmd;
        u8                                      bits_per_word;
        u8                                      bytes_per_word;
@@ -748,8 +746,6 @@ static int dspi_transfer_one_message(struct spi_controller *ctlr,
                                dspi->tx_cmd |= SPI_PUSHR_CMD_CONT;
                }
 
-               dspi->void_write_data = dspi->cur_chip->void_write_data;
-
                dspi->tx = transfer->tx_buf;
                dspi->rx = transfer->rx_buf;
                dspi->rx_end = dspi->rx + transfer->len;
@@ -848,8 +844,6 @@ static int dspi_setup(struct spi_device *spi)
                sck_cs_delay = pdata->sck_cs_delay;
        }
 
-       chip->void_write_data = 0;
-
        clkrate = clk_get_rate(dspi->clk);
        hz_to_spi_baud(&pbr, &br, spi->max_speed_hz, clkrate);