]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: hda/senary: Use codec->core.afg for GPIO access
authorwangdicheng <wangdicheng@kylinos.cn>
Tue, 3 Mar 2026 05:42:42 +0000 (13:42 +0800)
committerTakashi Iwai <tiwai@suse.de>
Tue, 3 Mar 2026 06:59:47 +0000 (07:59 +0100)
Replace the hardcoded GPIO node ID (0x01) with codec->core.afg.
This follows the standard HDA driver practice and makes the driver
more robust against different hardware configurations.

Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
Link: https://patch.msgid.link/20260303054242.318062-1-wangdich9700@163.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/codecs/senarytech.c

index 3a50d4b3a06465c7eec2396de6b8bc7ed97fd036..8822d4dc5e36afa2548c643a0af8a36ec1b9aea9 100644 (file)
@@ -19,9 +19,6 @@
 #include "hda_jack.h"
 #include "generic.h"
 
-/* GPIO node ID */
-#define SENARY_GPIO_NODE       0x01
-
 struct senary_spec {
        struct hda_gen_spec gen;
 
@@ -123,11 +120,11 @@ static void senary_init_gpio_led(struct hda_codec *codec)
        unsigned int mask = spec->gpio_mute_led_mask | spec->gpio_mic_led_mask;
 
        if (mask) {
-               snd_hda_codec_write(codec, SENARY_GPIO_NODE, 0, AC_VERB_SET_GPIO_MASK,
+               snd_hda_codec_write(codec, codec->core.afg, 0, AC_VERB_SET_GPIO_MASK,
                                    mask);
-               snd_hda_codec_write(codec, SENARY_GPIO_NODE, 0, AC_VERB_SET_GPIO_DIRECTION,
+               snd_hda_codec_write(codec, codec->core.afg, 0, AC_VERB_SET_GPIO_DIRECTION,
                                    mask);
-               snd_hda_codec_write(codec, SENARY_GPIO_NODE, 0, AC_VERB_SET_GPIO_DATA,
+               snd_hda_codec_write(codec, codec->core.afg, 0, AC_VERB_SET_GPIO_DATA,
                                    spec->gpio_led);
        }
 }