Explain why the XXXX021 in connection_or.c was there, and explain why it doesn' actua...

svn:r17819

diff --git a/src/or/connection_or.c b/src/or/connection_or.c
index 8125afdab9329156a7ca38d5b797a29e07ca8304..bfd3a71b8178f6568d2d28574c8c3b8ed3f503c5 100644 (file)
--- a/src/or/connection_or.c
+++ b/src/or/connection_or.c
@@ -633,7 +633,15 @@ connection_or_group_set_badness(or_connection_t *head)
    * every other open connection.  If it's non-canonical, mark as bad
    * every other open connection to the same address.
    *
-   * XXXX021.
+   * XXXX This isn't optimal; if we have connections to an OR at multiple
+   *   addresses, we'd like to pick the best _for each address_, and mark as
+   *   bad every open connection that isn't best for its address.  But this
+   *   can only occur in cases where the other OR is old (so we have no
+   *   canonical connection to it), or where all the connections to the OR are
+   *   at noncanonical addresses and we have no good direct connection (which
+   *   means we aren't at risk of attaching circuits to it anyway).  As
+   *   0.1.2.x dies out, the first case will go away, and the second one is
+   *   "mostly harmless", so a fix can wait until somebody is bored.
    */
   for (or_conn = head; or_conn; or_conn = or_conn->next_with_same_id) {
     if (or_conn->_base.marked_for_close ||