]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Check tor_sscanf return value in test_crypto.c
authorNick Mathewson <nickm@torproject.org>
Mon, 6 Jun 2016 14:01:50 +0000 (10:01 -0400)
committerNick Mathewson <nickm@torproject.org>
Mon, 6 Jun 2016 14:01:50 +0000 (10:01 -0400)
Coverity noticed that we check tor_sscanf's return value everywhere
else.

src/test/test_crypto.c

index c128333c204d5dee2e95d9b75f1a85e5324a8e21..d3e12b69b798fbaa800b4348ecd6e3677ba1f165 100644 (file)
@@ -162,7 +162,8 @@ test_crypto_openssl_version(void *arg)
   tt_assert(!strcmpstart(version, h_version)); /* "-fips" suffix, etc */
   tt_assert(!strstr(version, "OpenSSL"));
   int a=-1,b=-1,c=-1;
-  tor_sscanf(version, "%d.%d.%d", &a,&b,&c);
+  int r = tor_sscanf(version, "%d.%d.%d", &a,&b,&c);
+  tt_int_op(r, OP_EQ, 3);
   tt_int_op(a, OP_GE, 0);
   tt_int_op(b, OP_GE, 0);
   tt_int_op(c, OP_GE, 0);